chore: [DSYS-616] replace single Jazzicon instance and update @deprecated JSDoc#30255
Draft
cursor[bot] wants to merge 1 commit into
Draft
chore: [DSYS-616] replace single Jazzicon instance and update @deprecated JSDoc#30255cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…tarAccount Migrate Identicon from legacy AvatarAccount to @metamask/design-system-react-native with variant/address/size mapping. Point legacy AvatarAccount JSDoc @see links to Jazzicon RN README and MIGRATION anchor for DSYS-638 docs version 43e1619c7bbe3eafa9c210a8c69f0b1c1c90f135. Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
DSYS_EPIC: DSYS-616
This change picks up MMDS migration documentation from MetaMask/metamask-design-system PR 1138 (
MIGRATION_DOCS_VERSION/ docs commit43e1619c7bbe3eafa9c210a8c69f0b1c1c90f135).app/components/UI/Identicon/index.tsxnow renders account art viaAvatarAccountfrom@metamask/design-system-react-native, mapping legacyAvatarAccountType/AvatarSizetoAvatarAccountVariant/AvatarAccountSizeso Jazzicon, Blockies, and Maskicon paths use the design-system implementation (including the tempJazziconexport) instead of the legacycomponent-libraryAvatarAccountfor this callsite.AvatarAccountentry point@deprecatednow includes exactly two@seelinks targeting the RN Jazzicon README path and the#jazzicon-temp-componentanchor inMIGRATION.md, per DSYS-616 contract.Processed MIGRATION_DOCS_VERSION: 43e1619c7bbe3eafa9c210a8c69f0b1c1c90f135
Changelog
CHANGELOG entry: null
Related issues
Fixes: DSYS-638
Migration doc discrepancies found
.../src/components/Jazzicon/README.mddoes not resolve onmainat the audited docs commit; the RN Jazzicon README lives underpackages/design-system-react-native/src/components/temp-components/Jazzicon/README.md(see design-system tree at43e1619c7bbe3eafa9c210a8c69f0b1c1c90f135). The@seelink uses the contract path; consumers should follow the temp-components path in the repository when the README 404s from the shorter URL.AvatarAccountcomposes temp identicon primitives with upstreamAvatarBasedefaults that can differ from the legacy mobileAvatarAccountwrapper; QA should spot-check Identicon rendering (shape/cropping) for Jazzicon, Blockies, and Maskicon settings.Manual testing steps
Screenshots/Recordings
N/A (behavioral parity expected; spot-check recommended).
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist